feat(agents-api): Add some LiteLLM exceptions to the list of non-retryable errors #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 018360c in 16 seconds
More details
- Looked at
40lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/common/exceptions/tasks.py:99
- Draft comment:
ServiceUnavailableErroris typically a retryable error, as it might indicate a temporary issue. Consider if this should be non-retryable. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is speculative, suggesting a reconsideration of the classification ofServiceUnavailableError. However, the file's purpose is to define non-retryable errors, and the inclusion ofServiceUnavailableErrorseems intentional. The comment does not provide strong evidence that a change is required, as it is based on a typical scenario rather than a definite issue.
I might be overlooking the possibility thatServiceUnavailableErroris commonly considered retryable in other contexts, which could justify the comment. However, without strong evidence or a clear mandate to change the classification, the comment remains speculative.
The comment lacks strong evidence and is speculative, which does not align with the rules for review comments. It suggests a reconsideration without a definitive need for change.
The comment should be deleted as it is speculative and does not provide strong evidence for a required code change.
Workflow ID: wflow_jgKYGnUxagzMCe6V
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following exceptions:
litellm.exceptions.NotFoundError.litellm.exceptions.InvalidRequestError.litellm.exceptions.AuthenticationError.litellm.exceptions.ServiceUnavailableError.litellm.exceptions.OpenAIError.litellm.exceptions.APIError.Important
Add LiteLLM exceptions to non-retryable errors in
tasks.py.litellm.exceptions.NotFoundError,InvalidRequestError,AuthenticationError,ServiceUnavailableError,OpenAIError, andAPIErrortoNON_RETRYABLE_ERROR_TYPESintasks.py.This description was created by
for 018360c. It will automatically update as commits are pushed.